[wicketd] make installinator_progress cancel safe#3579
Merged
sunshowers merged 5 commits intoJul 13, 2023
Merged
Conversation
Created using spr 1.3.4
jgallagher
reviewed
Jul 12, 2023
Created using spr 1.3.4
Created using spr 1.3.4
Created using spr 1.3.4
jgallagher
approved these changes
Jul 12, 2023
sunshowers
added a commit
that referenced
this pull request
Aug 29, 2023
This was originally changed to an unbounded receiver in #3579, but in the comments to RFD 400 it was pointed out that maybe we shouldn't give up on backpressure. Switch to a watch channel, since we only care about the last element anyway. Also treat the receiver being closed as HTTP 410 Gone. We don't do anything with this at the moment, but could abort installinator on receiving this signal in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code currently uses a Tokio mutex and is currently not cancel-safe
(
RunningUpdatecan be invalid across an await point). Make itcancel-safe by using an unbounded receiver.
This means that we can replace Tokio's mutex with
std::sync::Mutex, and make these methods synchronous.