pass initial TLS certificates into RSS#3073
Merged
Merged
Conversation
…must use a hostname for TLS validation to work
luqmana
reviewed
May 11, 2023
luqmana
left a comment
Contributor
There was a problem hiding this comment.
a few minor comments but looks good thanks. i would update the how-to-run doc at least to make mention of this
Collaborator
Author
|
Thanks for the review! I think I addressed the feedback in 57b9eec. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, RSS always provides an empty list of initial TLS certificates (for the external API) to Nexus during rack initialization. On a real system, the user will provide the initial certificate over the technician port during initial setup (see RFDs 57, 323). This means Wicket will get them, and it will need to provide them to RSS. This PR adds these as a parameter to RSS's rack-initialize endpoint.
This affects different environments:
Fixes #1528.
This also addresses one of the two remaining items in #1529. The other one is notifying Nexus instances when one of them receives a certificate update. In an upcoming PR, I intend to instead have Nexus instances have a background task to monitor the list of certs.