Move Gateway configuration out of Sled Agent, into RSS#1529
Merged
Conversation
smklein
commented
Aug 1, 2022
Comment on lines
+47
to
+52
| // NOTE: This information is currently being configured and sent from RSS, | ||
| // but it contains dynamic information that could plausibly change during | ||
| // the duration of the sled's lifetime. | ||
| // | ||
| // Longer-term, it probably makes sense to store this in CRDB and transfer | ||
| // it to Sled Agent as part of the request to launch Nexus. |
Collaborator
Author
There was a problem hiding this comment.
To elaborate a bit on this comment, I believe this PR accomplishes #1527 by moving the gateway information from:
"must be known at package time" (bundled with Sled Agent)
to
"must be known at RSS time" (set once when configuring Sled Agent)
It probably makes sense to migrate this further, to:
"must be known when launching Nexus (and can be modified on a live system)"
bnaecker
reviewed
Aug 1, 2022
bnaecker
approved these changes
Aug 1, 2022
Collaborator
|
Fair enough, I didn’t mean to imply we’d explicitly provide the switch this value, only that it might be learned by the switch through a discovery protocol. ARP is what I had in mind though that might not be right.
… On 1 Aug 2022, at 17:08, Robert Mustacchi ***@***.***> wrote:
@rmustacc commented on this pull request.
In smf/sled-agent/config-rss.toml:
> @@ -11,6 +11,22 @@ rack_subnet = "fd00:1122:3344:0100::"
# For values less than 2, no rack secret will be generated.
rack_secret_threshold = 1
+[gateway]
+
+# IP address of Internet gateway
+#
+# NOTE: In the lab, use "172.20.15.225"
+# address = "192.168.1.1"
+
+# MAC address of the internet gateway in the local network, i.e., of the above
+# IP address.
+#
+# NOTE: This is currently configured for the lab. Developers should override
+# this with whatever value they wish to provide inbound connectivity to guests
+# in their local network, using the current workaround methods in OPTE. See
+# how-to-run.adoc for details on how to determine the value for your network.
+mac = "00:0d:b9:54:fe:e4"
The switch itself may not even know the MAC address. For IP level connectivity we will never be asking customers about MAC addresses. The only exception may be for some particular routing config or allow/deny list / lldp.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because your review was requested.
|
leftwo
pushed a commit
that referenced
this pull request
Nov 19, 2024
No Propolis changes other than to update Crucible Crucible changes are: Add debug/timeout to test_memory.sh (#1563) Consolidate ack checking (#1561) Rename for crutest: RegionInfo -> DiskInfo (#1562) Fix dtrace system level scripts (#1560) Remove `ackable_work`; ack immediately instead (#1552) No more New jobs, no more New jobs column (#1559) Remove delay-based backpressure in favor of explicit queue limits (#1515) Only send flushes when Downstairs is idle; send Barrier otherwise (#1505) Update Rust crate reqwest to v0.12.9 (#1536) Update Rust crate omicron-zone-package to 0.11.1 (#1535) Remove separate validation array (#1522) Remove more unnecessary `DsState` variants (#1550) Consolidate `DownstairsClient::reinitialize` (#1549) Update Rust crate uuid to v1.11.0 (#1546) Update Rust crate reedline to 0.36.0 (#1544) Update Rust crate bytes to v1.8.0 (#1541) Update Rust crate thiserror to v1.0.66 (#1539) Update Rust crate serde_json to v1.0.132 (#1538) Update Rust crate serde to v1.0.214 (#1537) Remove transient states in `DsState` (#1526) Update Rust crate libc to v0.2.161 (#1534) Update Rust crate futures to v0.3.31 (#1532) Update Rust crate clap to v4.5.20 (#1531) Update Rust crate async-trait to 0.1.83 (#1530) Update Rust crate anyhow to v1.0.92 (#1529) Remove obsolete crutest perf test (#1528) Update dependency rust to v1.82.0 (#1512) Still more updates to support Volume layer activities. (#1508) Remove remaining IOPS/bandwidth limiting code (#1525) Add unit test for VersionMismatch (#1524) Removing panic paths by only destructuring once (#1523) Update actions/checkout digest to 11bd719 (#1518) Switch to using `Duration` for times (#1520)
leftwo
added a commit
that referenced
this pull request
Nov 20, 2024
No Propolis changes other than to update Crucible Crucible changes are: Add debug/timeout to test_memory.sh (#1563) Consolidate ack checking (#1561) Rename for crutest: RegionInfo -> DiskInfo (#1562) Fix dtrace system level scripts (#1560) Remove `ackable_work`; ack immediately instead (#1552) No more New jobs, no more New jobs column (#1559) Remove delay-based backpressure in favor of explicit queue limits (#1515) Only send flushes when Downstairs is idle; send Barrier otherwise (#1505) Update Rust crate reqwest to v0.12.9 (#1536) Update Rust crate omicron-zone-package to 0.11.1 (#1535) Remove separate validation array (#1522) Remove more unnecessary `DsState` variants (#1550) Consolidate `DownstairsClient::reinitialize` (#1549) Update Rust crate uuid to v1.11.0 (#1546) Update Rust crate reedline to 0.36.0 (#1544) Update Rust crate bytes to v1.8.0 (#1541) Update Rust crate thiserror to v1.0.66 (#1539) Update Rust crate serde_json to v1.0.132 (#1538) Update Rust crate serde to v1.0.214 (#1537) Remove transient states in `DsState` (#1526) Update Rust crate libc to v0.2.161 (#1534) Update Rust crate futures to v0.3.31 (#1532) Update Rust crate clap to v4.5.20 (#1531) Update Rust crate async-trait to 0.1.83 (#1530) Update Rust crate anyhow to v1.0.92 (#1529) Remove obsolete crutest perf test (#1528) Update dependency rust to v1.82.0 (#1512) Still more updates to support Volume layer activities. (#1508) Remove remaining IOPS/bandwidth limiting code (#1525) Add unit test for VersionMismatch (#1524) Removing panic paths by only destructuring once (#1523) Update actions/checkout digest to 11bd719 (#1518) Switch to using `Duration` for times (#1520) Co-authored-by: Alan Hanson <alan@oxide.computer>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1527