Skip to content

IAM: support assigning roles on Silos#1044

Merged
davepacheco merged 7 commits into
mainfrom
role-assignments-silos
May 9, 2022
Merged

IAM: support assigning roles on Silos#1044
davepacheco merged 7 commits into
mainfrom
role-assignments-silos

Conversation

@davepacheco

Copy link
Copy Markdown
Collaborator

Continuing the line from #1002 and #1042. (There will be one more for global assignments after this.)

@davepacheco davepacheco requested a review from plotnick May 9, 2022 18:02
@davepacheco

Copy link
Copy Markdown
Collaborator Author

This is blocked on #1042 so I'm leaving it "draft" (so I don't accidentally merge it). But it's otherwise ready for review.

@davepacheco davepacheco mentioned this pull request May 9, 2022
69 tasks
Base automatically changed from role-assignments to main May 9, 2022 20:24
@davepacheco davepacheco marked this pull request as ready for review May 9, 2022 20:32

@plotnick plotnick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The need for the always_visible flag to do_test seems slightly unfortunate; let's make sure to come back to those TODOs as soon as we can. But otherwise this looks fine to me - no surprises given #1042.

@davepacheco davepacheco merged commit 0cb9a82 into main May 9, 2022
@davepacheco davepacheco deleted the role-assignments-silos branch May 9, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants