IAM: support assigning roles on Projects#1042
Merged
Merged
Conversation
69 tasks
plotnick
approved these changes
May 9, 2022
plotnick
left a comment
Contributor
There was a problem hiding this comment.
Looks great. Nice job setting up the datastore layer so that this just worked with no modifications. As in pool, the tricky bit is not just getting this shot in, but setting up the next one, too.
| opctx: &OpContext, | ||
| organization_name: &Name, | ||
| ) -> LookupResult<shared::Policy<OrganizationRoles>> { | ||
| ) -> LookupResult<shared::Policy<authz::OrganizationRoles>> { |
Contributor
There was a problem hiding this comment.
This is definitely clearer with the explicit authz package prefix.
| ] | ||
| }, | ||
| "ProjectRolesPolicy": { | ||
| "description": "Client view of a [`Policy`], which describes how this resource may be accessed\n\nNote that the Policy only describes access granted explicitly for this resource. The policies of parent resources can also cause a user to have access to this resource.", |
Contributor
There was a problem hiding this comment.
Really nice description, should help avoid some end-user questions.
| let org_name = "test-org"; | ||
| create_organization(client, org_name).await; | ||
| let org_url = format!("/organizations/{}", org_name); | ||
| do_test::<_, views::Organization>( |
Contributor
There was a problem hiding this comment.
I think I'd prefer an explicit type for T here (and below on line 47) rather than a wildcard. Not a big deal, just might save some brain cycles when reading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty straightforward extension of #1002 that adds support for assigning roles on Projects.