Conversation
bnaecker
reviewed
May 10, 2022
bnaecker
reviewed
May 10, 2022
bnaecker
left a comment
Collaborator
There was a problem hiding this comment.
This all looks totally cool to me. Thanks for your attention to detail here, I think it'll be a big polish improvement!
| "V6" | ||
| ], | ||
| "additionalProperties": false | ||
| ] |
Contributor
There was a problem hiding this comment.
What's the upshot of the allOf change?
Contributor
Author
There was a problem hiding this comment.
This is explained... some? .. in the code here:
progenitor (via typify) will see this title field and use this as the label for an enum. So it will construct the type so that it matches the original IpNet.
I've opened an issue with schemars to have this in untagged schemas (which would do this automatically for us here): GREsau/schemars#102
david-crespo
approved these changes
May 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still a WIP, but only insofar as it depends on some in-flight changes for openapi-lint, progenitor, and typify.
This makes omicron conform to the updated openapi-lint per oxidecomputer/openapi-lint#7
Most significantly:
#[serde(rename_all = "snake_case")](unless they're all caps such as withDnsRecord)IpNeteffectively becomes astringwith various formatting constraints..Default::default()