Conversation
Dependency bumps (dropshot/Cargo.toml):
- rustls 0.22.4 → 0.23.38 (explicit aws_lc_rs feature, no ring).
- tokio-rustls 0.25.0 → 0.26.4 (explicit aws_lc_rs feature, no ring)
- hyper-rustls 0.26.0 → 0.27.9 (defaults already aws-lc-rs)
- reqwest 0.12.28 → 0.13.2, renamed feature rustls-tls → rustls
- rcgen 0.14.7 with default features replaced by aws_lc_rs, pem (drops
ring)
Updated `test_with_tls`; reqwest deprecated `add_root_certificate` in
favor of `tls_certs_only`.
ahl
approved these changes
Apr 27, 2026
ahl
left a comment
Collaborator
There was a problem hiding this comment.
looks good; thanks for this.
notpeter
added a commit
to oxidecomputer/v-api
that referenced
this pull request
May 1, 2026
Remove `ring` and `rust_crypto` in favor of `aws_lc_rs`. Probably only worth doing if Dropshot also switches from `ring` to `aws_lc_rs`: - oxidecomputer/dropshot#1590
This was referenced May 13, 2026
|
Hey y'all, worth noting that by bumping
Whenever |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Switch dependencies from
ringtoaws_lc_rs.Dependency bumps (dropshot/Cargo.toml):
Other changes:
test_with_tls; reqwest deprecatedadd_root_certificatein favor oftls_certs_only.Thinking
Currently Dropshot depends on Ring for crypto. I'm proposing we switch to
aws-lc.When updating dependencies for some Dropshot services (turnstile, rfd-api, four-star) we were forced to build both
aws-lc-rs(other deps) andring(for dropshot) which felt redundant/unnecessary.Following rustls moving it's default backend from Ring to
aws-lcin 0.23.0, multiple other libraries have followed suit. Many have removed ring as their default and other are removing Ring support altogether.aws-lcinstead of Ring, which is still available viarustls-ringfeature.aws_lc_rsas default backend; Ring still available viaringfeature.aws_lc_rsas default backendaws_lc_rsorrust_crypto, no ring supportChoices
I'm not sure whether it's worth the complexity to support multiple backends via feature flags instead of just switching from
ringtoaws-lc-rs, but it's certainly an option.Other Notes
ringas a default feature, but fully supportsaws_lc.aws-lc.aws-lccrate does support afipsfeature flag. I have no investigated this.aws-lc-sysis a bit finicky to build, particularly when trying to cross-compile (with cargo-zigbuild) and with certain compilers/platforms (Windows and MSVCC). Our Windows issues were fixed upstream and workarounds exist, but it's definitely worth mentioning that there is significant build complexity in the underlying aws-lc C project (CMake, etc).