Order packages topologically#1097
Merged
Merged
Conversation
This was referenced Jan 12, 2024
Contributor
Author
|
@karencfv : This should hopefully unblock you, I filed oxidecomputer/omicron-package#56 to pull this out as a more general-purpose utility in the |
karencfv
approved these changes
Jan 14, 2024
karencfv
left a comment
Contributor
There was a problem hiding this comment.
Ha! That's what was missing, mystery solved. Thanks a million for looking into this 🙇♀️ !
leftwo
approved these changes
Jan 15, 2024
smklein
added a commit
to oxidecomputer/omicron-package
that referenced
this pull request
Jan 15, 2024
This is basically oxidecomputer/crucible#1097 , but generalized and with tests Adds support for topologically sorting packages, so they can be built in dependency-first order. Fixes #56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't make much of a difference for
main, but it matters for an upcoming PR which adds more complexity to the Crucible build process: #1096 (reasonably so! the network service will be great to have)Previously, Crucible packages were ordered according to the parsed order of the TOML file (which appears to have been alphabetical). With this PR, packages are now sorted topologically, so that "dependencies are built first".
Also, improved logging for error cases where dependencies cannot be found.