Boot order#2464
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Instance create works2024-09-23-boot-disk-instance-create.mp4 |
|
I think separate from the badge treatment, there's something here about having a button and a modal to select the boot disk. I had originally made this for NICs. But I think we need some way hoisted up that isn't just in the more actions menu. 
See also the designs I had for separate boot disk: 
|
5dc7e49 to
2280633
Compare
| modalContent: ( | ||
| <p> | ||
| Are you sure you want to unset <HL>{disk.name}</HL> as the boot disk? This | ||
| will TODO COPY RE: WHAT HAPPENS HERE |
| const makeActions = useCallback( | ||
| const { mutateAsync: instanceUpdate } = useApiMutation('instanceUpdate', { | ||
| onSuccess() { | ||
| apiQueryClient.invalidateQueries('instanceView') |
There was a problem hiding this comment.
perhaps add an addToast({ content: 'Your instance has been updated' }) here?
There was a problem hiding this comment.
Good idea, though I think it would be even better if it was specific to the action — this is used for both set and unset boot disk. So it needs to be triggered at each call site. That might require moving this invalidate there because I think if you pass onSuccess as an option at call time it will override this one.
charliepark
left a comment
There was a problem hiding this comment.
Added a few non-blocking comments, but front-end code all looks good; will defer to @iximeow on API and boot order backend particulars, though.
|
Can't tell if I'm cooking or this is ridiculous. 2024-10-01-boot-disk-messages-2.mp4 |
|
ooh, i do like that it's contextually as-helpful-as-we-can-be. as for what happens without a boot disk: you get the status quo. so the guest will probably try booting disks in PCI device order (which i don't think we really expose in a useful way), but as evidenced by oxidecomputer/omicron#5112 it's quite possible that one of the disks has an EFI System Partition that ends up with the EFI shell tried before the right disk and then everything gets stuck. i think an informative way to present that would be something like: "With no boot disk, the instance will try booting based on UEFI variables of the first disk with an EFI System Partition". it's really the same behavior with one or multiple disks. but "first" still means "lowest PCI device number", so i think that's still less actionable than ideal? this makes me wonder if it's possible to end up in a #5112-like state with even a single disk.. |
|
That’s helpful, though indirectly, because to me the main thing it says is there’s no good way to explain this concisely enough in the UI and we should focus on encouraging them to set a boot disk if there’s more than one, and lean on the docs link for explanation. |
|
Going with this for now for the multiple non-boot disks case. 
|
|
Added a TODO for docs links in the modal footer. Confirm set boot disk when there isn't one currently
Confirm set boot disk when there is one currently
Confirm unset boot disk
|
e645a6a to
17e9a37
Compare
oxidecomputer/console@5561f28...073471c * [073471c4](oxidecomputer/console@073471c4) mock api: disks are created straight into detached state * [612ec90c](oxidecomputer/console@612ec90c) oxidecomputer/console#2485 * [614f1bb5](oxidecomputer/console@614f1bb5) oxidecomputer/console#2466 * [df2dc14c](oxidecomputer/console@df2dc14c) bump vite related deps for a weird vuln * [a030b9e0](oxidecomputer/console@a030b9e0) oxidecomputer/console#2464 * [dec48497](oxidecomputer/console@dec48497) oxidecomputer/console#2461 * [e46216aa](oxidecomputer/console@e46216aa) oxidecomputer/console#2482 * [0d897efe](oxidecomputer/console@0d897efe) oxidecomputer/console#2479 * [f88790db](oxidecomputer/console@f88790db) oxidecomputer/console#2478 * [d634c8f0](oxidecomputer/console@d634c8f0) oxidecomputer/console#2477 * [eeaa14c3](oxidecomputer/console@eeaa14c3) oxidecomputer/console#2475 * [5ece6e18](oxidecomputer/console@5ece6e18) oxidecomputer/console#2467 * [4b699e01](oxidecomputer/console@4b699e01) oxidecomputer/console#2448 * [9c9dc149](oxidecomputer/console@9c9dc149) oxidecomputer/console#2465 * [1aa0fc9b](oxidecomputer/console@1aa0fc9b) oxidecomputer/console#2463 * [57db4054](oxidecomputer/console@57db4054) oxidecomputer/console#2462 * [da7fe328](oxidecomputer/console@da7fe328) oxidecomputer/console#2460 * [e0d52efd](oxidecomputer/console@e0d52efd) oxidecomputer/console#2437 * [1625d02a](oxidecomputer/console@1625d02a) oxidecomputer/console#2458 * [fd82458e](oxidecomputer/console@fd82458e) oxidecomputer/console#2457 * [7daaa337](oxidecomputer/console@7daaa337) oxidecomputer/console#2453
oxidecomputer/console@5561f28...073471c * [073471c4](oxidecomputer/console@073471c4) mock api: disks are created straight into detached state * [612ec90c](oxidecomputer/console@612ec90c) oxidecomputer/console#2485 * [614f1bb5](oxidecomputer/console@614f1bb5) oxidecomputer/console#2466 * [df2dc14c](oxidecomputer/console@df2dc14c) bump vite related deps for a weird vuln * [a030b9e0](oxidecomputer/console@a030b9e0) oxidecomputer/console#2464 * [dec48497](oxidecomputer/console@dec48497) oxidecomputer/console#2461 * [e46216aa](oxidecomputer/console@e46216aa) oxidecomputer/console#2482 * [0d897efe](oxidecomputer/console@0d897efe) oxidecomputer/console#2479 * [f88790db](oxidecomputer/console@f88790db) oxidecomputer/console#2478 * [d634c8f0](oxidecomputer/console@d634c8f0) oxidecomputer/console#2477 * [eeaa14c3](oxidecomputer/console@eeaa14c3) oxidecomputer/console#2475 * [5ece6e18](oxidecomputer/console@5ece6e18) oxidecomputer/console#2467 * [4b699e01](oxidecomputer/console@4b699e01) oxidecomputer/console#2448 * [9c9dc149](oxidecomputer/console@9c9dc149) oxidecomputer/console#2465 * [1aa0fc9b](oxidecomputer/console@1aa0fc9b) oxidecomputer/console#2463 * [57db4054](oxidecomputer/console@57db4054) oxidecomputer/console#2462 * [da7fe328](oxidecomputer/console@da7fe328) oxidecomputer/console#2460 * [e0d52efd](oxidecomputer/console@e0d52efd) oxidecomputer/console#2437 * [1625d02a](oxidecomputer/console@1625d02a) oxidecomputer/console#2458 * [fd82458e](oxidecomputer/console@fd82458e) oxidecomputer/console#2457 * [7daaa337](oxidecomputer/console@7daaa337) oxidecomputer/console#2453
Preview: https://console-git-boot-order-oxidecomputer.vercel.app/projects/mock-project/instances/db1/storage
Closes #2335. Depends on oxidecomputer/omicron#6585.
2024-10-02-boot-disk-demo-2.mp4