update inventory sidebar link#2238
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
|
There are some loader and back button shenanigans that can happen when you link to the parent and rely on the replace nav. I’ll show you Monday how to test it out. If it doesn’t work well we might have to get more clever with the active style logic to match on Lines 151 to 160 in efceb17 |
david-crespo
approved these changes
May 20, 2024
david-crespo
left a comment
Collaborator
There was a problem hiding this comment.
Exorcised my worry in #2253. Could not find any issues with this approach. We may want to update some other route tab pages in followup PRs if they have the same problem.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
May 22, 2024
oxidecomputer/console@078d171...a228b75 * [a228b75b](oxidecomputer/console@a228b75b) bump omicron (only one tiny diff in validators) * [fc91ec1e](oxidecomputer/console@fc91ec1e) oxidecomputer/console#2256 * [39b4491e](oxidecomputer/console@39b4491e) oxidecomputer/console#2230 * [e4e912ca](oxidecomputer/console@e4e912ca) oxidecomputer/console#2247 * [dcf09ec9](oxidecomputer/console@dcf09ec9) oxidecomputer/console#2217 * [c36b3d63](oxidecomputer/console@c36b3d63) oxidecomputer/console#2238 * [a8eb7745](oxidecomputer/console@a8eb7745) oxidecomputer/console#2251 * [9b20b7c9](oxidecomputer/console@9b20b7c9) oxidecomputer/console#2248 * [f20a5bcb](oxidecomputer/console@f20a5bcb) oxidecomputer/console#2245 * [b815dd8f](oxidecomputer/console@b815dd8f) oxidecomputer/console#2244 * [8c7b2946](oxidecomputer/console@8c7b2946) add node_modules to eslint ignore patterns * [90e78dbb](oxidecomputer/console@90e78dbb) oxidecomputer/console#2237 * [b603d2dd](oxidecomputer/console@b603d2dd) oxidecomputer/console#2242 * [bfce37c7](oxidecomputer/console@bfce37c7) upgrade @oxide/openapi-gen-ts to 0.2.2 * [efceb17d](oxidecomputer/console@efceb17d) oxidecomputer/console#2236 * [1aa46459](oxidecomputer/console@1aa46459) oxidecomputer/console#2235 * [b400ae78](oxidecomputer/console@b400ae78) oxidecomputer/console#2225 * [7bb3bbf7](oxidecomputer/console@7bb3bbf7) oxidecomputer/console#2229 * [c56a9ec5](oxidecomputer/console@c56a9ec5) oxidecomputer/console#2228 * [cd9d1f99](oxidecomputer/console@cd9d1f99) oxidecomputer/console#2227 * [ee269bd9](oxidecomputer/console@ee269bd9) oxidecomputer/console#2223
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
May 22, 2024
Highlights: soft image validation, logout button on error pages to help deal with auth-related errors. oxidecomputer/console@078d171...a228b75 * [a228b75b](oxidecomputer/console@a228b75b) bump omicron (only one tiny diff in validators) * [fc91ec1e](oxidecomputer/console@fc91ec1e) oxidecomputer/console#2256 * [39b4491e](oxidecomputer/console@39b4491e) oxidecomputer/console#2230 * [e4e912ca](oxidecomputer/console@e4e912ca) oxidecomputer/console#2247 * [dcf09ec9](oxidecomputer/console@dcf09ec9) oxidecomputer/console#2217 * [c36b3d63](oxidecomputer/console@c36b3d63) oxidecomputer/console#2238 * [a8eb7745](oxidecomputer/console@a8eb7745) oxidecomputer/console#2251 * [9b20b7c9](oxidecomputer/console@9b20b7c9) oxidecomputer/console#2248 * [f20a5bcb](oxidecomputer/console@f20a5bcb) oxidecomputer/console#2245 * [b815dd8f](oxidecomputer/console@b815dd8f) oxidecomputer/console#2244 * [8c7b2946](oxidecomputer/console@8c7b2946) add node_modules to eslint ignore patterns * [90e78dbb](oxidecomputer/console@90e78dbb) oxidecomputer/console#2237 * [b603d2dd](oxidecomputer/console@b603d2dd) oxidecomputer/console#2242 * [bfce37c7](oxidecomputer/console@bfce37c7) upgrade @oxide/openapi-gen-ts to 0.2.2 * [efceb17d](oxidecomputer/console@efceb17d) oxidecomputer/console#2236 * [1aa46459](oxidecomputer/console@1aa46459) oxidecomputer/console#2235 * [b400ae78](oxidecomputer/console@b400ae78) oxidecomputer/console#2225 * [7bb3bbf7](oxidecomputer/console@7bb3bbf7) oxidecomputer/console#2229 * [c56a9ec5](oxidecomputer/console@c56a9ec5) oxidecomputer/console#2228 * [cd9d1f99](oxidecomputer/console@cd9d1f99) oxidecomputer/console#2227 * [ee269bd9](oxidecomputer/console@ee269bd9) oxidecomputer/console#2223
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2173
Currently, the sidebar link directs users to
/inventory/sleds, which means that the ReactRouter magicalisActiveprop doesn't know that it should be highlighted for either/inventory/sledsOR/inventory/disks. By changing the route to just/inventory, it matches for both, and so it highlights the sidebar item regardless of which tab they're on.