Better handling of mutable prim free names in flow analysis#991
Merged
mshinwell merged 4 commits intooxcaml:mainfrom Nov 28, 2022
Merged
Better handling of mutable prim free names in flow analysis#991mshinwell merged 4 commits intooxcaml:mainfrom
mshinwell merged 4 commits intooxcaml:mainfrom
Conversation
mshinwell
approved these changes
Nov 28, 2022
mshinwell
pushed a commit
that referenced
this pull request
Nov 29, 2022
mshinwell
pushed a commit
that referenced
this pull request
Nov 29, 2022
mshinwell
pushed a commit
that referenced
this pull request
Nov 29, 2022
mshinwell
pushed a commit
that referenced
this pull request
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now use the free_names function from Flambda_primitive instead of a manual (and as it turns out, buggy) re-implementation.
This should fix a bug related to regions not being properly tracked in some cases due to the new code for mutable unboxing.