(Possibly temporary) fix for meet_equals_tagged_immediates#729
Merged
mshinwell merged 1 commit intooxcaml:mainfrom Jul 14, 2022
Merged
(Possibly temporary) fix for meet_equals_tagged_immediates#729mshinwell merged 1 commit intooxcaml:mainfrom
mshinwell merged 1 commit intooxcaml:mainfrom
Conversation
Contributor
|
This doesn't look right. Is it possible that one of the JS modules cheats and uses an integer comparison on pointers for speed ? |
Contributor
|
For future reference, a bit of context from Slack:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the
Invalidseen on the JS builds (on a comparison primitive) and matches the semantics prior to #726. We can discuss whether this is the best solution when @lthls is back.