Merged
Conversation
The prove_* versions will return a Proof when the inputs type strictly matches the property in question, while the check_* functions will return a Known_result when the corresponding operation has a result that can be easily extracted. As an example, for untagging the `prove_tagging_of_simple` version will return Unknown on option-like variants, while the `check_tagging_of_simple` version will assume the block part of the type is irrelevant.
Fix prove/meet mixup in simplify_phys_equal
lthls
reviewed
Jul 13, 2022
lthls
approved these changes
Jul 13, 2022
Collaborator
Author
|
I also approve this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work is due almost entirely to @lthls and @chambart .
@lthls I added two more changesets: one only affects CR comments and the other just replaces some assertions with fatal errors.