Merged
Conversation
Refactor references into the stage1 and stage2 build directories to use the new `$(build_stage1)` and `$(build_stage2)` variables. Also factor out finding the right value for `ARCH` when calling into Dune. All of these will change soon, so this will make for much smaller diffs.
mshinwell
approved these changes
Nov 29, 2021
xclerc
added a commit
to xclerc/oxcaml
that referenced
this pull request
Dec 2, 2021
…oes not support `--relative`.
mshinwell
pushed a commit
that referenced
this pull request
Dec 3, 2021
…t support `--relative`. (#411)
mshinwell
pushed a commit
that referenced
this pull request
Dec 3, 2021
Refactor references into the stage1 and stage2 build directories to use the new `$(build_stage1)` and `$(build_stage2)` variables. Also factor out finding the right value for `ARCH` when calling into Dune. All of these will change soon, so this will make for much smaller diffs.
mshinwell
pushed a commit
that referenced
this pull request
Dec 3, 2021
…t support `--relative`. (#411)
mshinwell
pushed a commit
to mshinwell/oxcaml
that referenced
this pull request
Dec 3, 2021
Refactor references into the stage1 and stage2 build directories to use the new `$(build_stage1)` and `$(build_stage2)` variables. Also factor out finding the right value for `ARCH` when calling into Dune. All of these will change soon, so this will make for much smaller diffs.
mshinwell
pushed a commit
to mshinwell/oxcaml
that referenced
this pull request
Dec 3, 2021
…oes not support `--relative`. (oxcaml#411)
mshinwell
pushed a commit
that referenced
this pull request
Jan 14, 2022
Refactor references into the stage1 and stage2 build directories to use the new `$(build_stage1)` and `$(build_stage2)` variables. Also factor out finding the right value for `ARCH` when calling into Dune. All of these will change soon, so this will make for much smaller diffs.
mshinwell
pushed a commit
that referenced
this pull request
Jan 14, 2022
…t support `--relative`. (#411)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor references into the stage1 and stage2 build directories to use the new
$(build_stage1)and$(build_stage2)variables. Also factor out finding the right value forARCHwhen calling into Dune. All of these will change soon, so this will make for much smaller diffs.