Conversation
e83fad6 to
06b1b23
Compare
stedolan
reviewed
Mar 4, 2025
Contributor
|
This looks good, thanks! Will be good to finally get this patch merged. |
Closed
mshinwell
reviewed
Mar 5, 2025
mshinwell
reviewed
Mar 5, 2025
mshinwell
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased version of #2215 with the following additions:
caml_thread_structthat became redundantcaml_free_stack(previously leaked for every fiber). This also applies to domains and systhreads.stack->id; there's nothing to compare it withIf you run out of memory by creating too many fibers, you can get
Fatal error: allocation failure during minor GCwhen the minor GC tries tomalloca block. This seems unfortunate.