Closed
Conversation
90a71c0 to
6634a71
Compare
Collaborator
Author
|
I'm also going to put in this PR the re-enabling of tests disabled with the |
dae432c to
5eddd1b
Compare
Collaborator
|
Could you or @stedolan add some description to this PR of how this works, and some indication of what invariants it relies on to work? It's unclear whether this supports e.g. pointers to locals on a parent's stack. |
Collaborator
Author
Sure, I'll probably do this as comments in the code. |
cf4d38d to
74e9015
Compare
74e9015 to
69f0be7
Compare
69f0be7 to
836c794
Compare
ff995f5 to
1ea82a3
Compare
55f4a53 to
45657b8
Compare
c24865c to
f2f4873
Compare
Merged
Collaborator
Author
|
Superceded by #3648 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides support for local allocations in the presence of algebraic effects.
There aren't presently any clever optimisations, although care is taken to ensure that the code sequences generated by the OCaml compiler for local allocations remain unchanged. This is done by arranging for some of the per-stack locals state to be present at the root of
Caml_statein addition to being stored in thestack_infostructures.Based on #2205.