Use -O2 not -O3 for building flambda2#333
Closed
mshinwell wants to merge 1 commit intooxcaml:mainfrom
Closed
Conversation
poechsel
approved these changes
Oct 13, 2021
Contributor
Collaborator
|
Doesn't this suggest that O3 is now too aggressive? |
Contributor
|
We're currently looking at this a bit more in depth but it mostly seems to indicate that something might be wrong with the inlining depth. I've benchmarked the time stage2 was taking for different values of inlining_depth: With an inlining depth of 6 for -O2 it looks like:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The recent change to make
-O3more aggressive has slowed build times down for flambda2 significantly (+10 minutes for the CI checks). I think-O2is sufficient for this part of the code for the moment.