Merged
Conversation
(cherry picked from commit 422985c)
e1ef46e to
e5424e9
Compare
ccasin
approved these changes
Aug 28, 2024
Collaborator
ccasin
left a comment
There was a problem hiding this comment.
I am approving this because I think it does no harm and will unblock us, but I'm skeptical that it is needed. The upstream PR this backports was closed, not merged, and a fix was made in ppxlib instead - probably we should do the same?
We should discuss with @ncik-roberts next week to see if there's some reason he wanted to do it this way, but this is fine to merge in the mean time if it lets us make progress - we can always back it out later.
lukemaurer
pushed a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Oct 23, 2024
Backport 12991 (cherry picked from commit 422985c) Co-authored-by: Nick Roberts <nroberts@janestreet.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See mshinwell#36 .
@ccasin please review (but don't merge). You only need to look at
e1ef46e893e8bc95291a1adb4c25b54095a61eb8.This is based on #2973.