Share transl_modalities code with transl_modifiers and transl_modes#2925
Merged
Share transl_modalities code with transl_modifiers and transl_modes#2925
transl_modalities code with transl_modifiers and transl_modes#2925Conversation
riaqn
reviewed
Aug 15, 2024
liam923
commented
Aug 19, 2024
riaqn
approved these changes
Aug 29, 2024
b621ab0 to
f112f1c
Compare
riaqn
approved these changes
Aug 29, 2024
riaqn
added a commit
that referenced
this pull request
Sep 9, 2024
…des` (#2925) * Subsume transl_modalities into Typemode * Modify error message for unrecognized modifier and add jkind tests * Fix formatting * Add jkind_axis and refactor typemodifier into typemode * Reformat * some edits --------- Co-authored-by: Zesen Qian <github@riaqn.org>
lukemaurer
pushed a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Oct 23, 2024
…s` and `transl_modes` (oxcaml#2925) * Subsume transl_modalities into Typemode * Modify error message for unrecognized modifier and add jkind tests * Fix formatting * Add jkind_axis and refactor typemodifier into typemode * Reformat * some edits --------- Co-authored-by: Zesen Qian <github@riaqn.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2730 introduced
typemodifier.ml, which shares translation logic between jkinds and modes. But although the modality translation code was similar, it was not abstracted intotypemodifier.ml. This PR does so.