Monadic modalities always implied by mutable#2900
Merged
goldfirere merged 3 commits intomainfrom Aug 8, 2024
Merged
Conversation
goldfirere
reviewed
Aug 7, 2024
goldfirere
approved these changes
Aug 8, 2024
lukemaurer
pushed a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Oct 23, 2024
…#2900) * monadic modalities always implied by mutable * refactor the logic * add tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2716 introduced the
@no_mutable_implied_modalitiesattribute that disables the legacy modalities implied bymutable, including both monadic and comonadic axes.In the long run, the implication on the comonadic axes will be disabled by default, and this attribute allows us to experiment with that currently. However, the implication on the monadic axes will stay in the future (more details to be found in the internal doc "Modes and mutations") as it gives the best ergonomics. Therefore, the attribute should not affect the monadic axes. This PR fixes that.