Skip to content

Improve the modes in predef.ml#2876

Merged
riaqn merged 7 commits intomainfrom
modal-predef
Aug 6, 2024
Merged

Improve the modes in predef.ml#2876
riaqn merged 7 commits intomainfrom
modal-predef

Conversation

@riaqn
Copy link
Copy Markdown
Contributor

@riaqn riaqn commented Jul 31, 2024

This PR improves the modes in predef.ml. Please review by commits:

  • The first commit adds the interpretation of more mode annotation, to allow tests
  • The second commit adds the jkind mutable_data.
  • The third commit fixes up predef.ml in the following ways:
    • Add ~jkind to allow more mode crossing.
    • Add ~jkind_annotation when the corresponding ~jkind is not value
    • Add ~param_jkind to iarray, to require elements of iarray to be non-null.
    • Also some reformatting to avoid long lines.

@riaqn riaqn requested a review from goldfirere July 31, 2024 17:17
Copy link
Copy Markdown
Collaborator

@goldfirere goldfirere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Copy Markdown
Collaborator

@goldfirere goldfirere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops skipped tests on last review

@riaqn riaqn merged commit fb0e355 into main Aug 6, 2024
@riaqn riaqn deleted the modal-predef branch August 6, 2024 17:11
lukemaurer pushed a commit to lukemaurer/flambda-backend that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants