Ensure GC logs are printed atomically#2874
Merged
mshinwell merged 1 commit intooxcaml:mainfrom Aug 6, 2024
Merged
Conversation
mshinwell
approved these changes
Aug 6, 2024
mshinwell
pushed a commit
that referenced
this pull request
Aug 19, 2024
(cherry picked from commit 7e1b316)
lukemaurer
pushed a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Oct 23, 2024
lukemaurer
pushed a commit
that referenced
this pull request
Oct 23, 2024
(cherry picked from commit 7e1b316)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-domain GC logging can currently interleave timestamps and messages, making them hard to read. This patch formats the message into a local buffer before writing it in a single call to
fwrite, which makes the output nicer.