Merged
Conversation
goldfirere
reviewed
Jul 31, 2024
goldfirere
reviewed
Jul 31, 2024
goldfirere
reviewed
Aug 2, 2024
goldfirere
reviewed
Aug 2, 2024
goldfirere
reviewed
Aug 2, 2024
goldfirere
approved these changes
Aug 2, 2024
lukemaurer
pushed a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Oct 23, 2024
* `or_null_reexport` * fix `or_null` mli * fix test * Fixes * Variance and injectivity annotations * type parameter tests * more fixes --------- Co-authored-by: Diana Kalinichenko <dkalinichenko@janestreet.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
[@@or_null_reexport], an attribute for re-exporting the constructors of'a or_null, because they can't be defined by users.Between
type 'a t [@@or_null_reexport]andtype 'a t = 'a or_null [@@or_null_reexport]this PR chooses the latter to avoid unnecessary work intypedecl.ml. With the manifest set by user, we can delay updatingtype_kinduntil relatively late in typechecking.Also fix
or_null.mlito use'a tinstead of'a or_null.