Recover #2669 (Tail-position local_ no longer means local-returning)#2842
Merged
Recover #2669 (Tail-position local_ no longer means local-returning)#2842
Conversation
7426758 to
c4fac89
Compare
goldfirere
approved these changes
Jul 24, 2024
Collaborator
goldfirere
left a comment
There was a problem hiding this comment.
Last two commits (Fix test and Fix chamelon) only
lukemaurer
pushed a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Oct 23, 2024
…means local-returning) (oxcaml#2842)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR recoveres #2669, which makes tail-position
localno longer mean local-returning, and fixes a BUG intmc.ml.That PR was messed up and in the end only updates the document.
All commits in this PR, except the last two, are from the original #2669 and reviewed. Therefore, only the last two commit needs review.