Update arrow types to cross contention and uniqueness#2835
Merged
Conversation
liam923
commented
Jul 22, 2024
Contributor
Author
|
Some tests are failing on CI but succeeding locally. I need to figure out what's going on. |
goldfirere
approved these changes
Jul 23, 2024
riaqn
reviewed
Jul 23, 2024
Contributor
Author
Turns out this was just because I needed to merge in changes from main. |
Contributor
Author
|
This is now ready for re-review @riaqn |
Contributor
|
Thank you - I realized that some of the tests is no longer useful so I removed them. Feel free to merge once CI green. Thanks! |
ncik-roberts
pushed a commit
that referenced
this pull request
Jul 26, 2024
* Update arrow types to cross contention and uniqueness * Remove arg_type and ret_type from for_arrow * Fix typo in test portable-contend.ml * Fix failing tests * Update cr * remove bad tests --------- Co-authored-by: Zesen Qian <github@riaqn.org>
lukemaurer
pushed a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Oct 23, 2024
oxcaml#2835) * Update arrow types to cross contention and uniqueness * Remove arg_type and ret_type from for_arrow * Fix typo in test portable-contend.ml * Fix failing tests * Update cr * remove bad tests --------- Co-authored-by: Zesen Qian <github@riaqn.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.