Fix more cases of zero_alloc / modality variables getting into signatures#2827
Merged
riaqn merged 3 commits intooxcaml:mainfrom Jul 22, 2024
Merged
Fix more cases of zero_alloc / modality variables getting into signatures#2827riaqn merged 3 commits intooxcaml:mainfrom
zero_alloc / modality variables getting into signatures#2827riaqn merged 3 commits intooxcaml:mainfrom
Conversation
Collaborator
Author
|
Request review from @riaqn |
c6028e8 to
0d3bfa5
Compare
riaqn
approved these changes
Jul 22, 2024
Contributor
riaqn
left a comment
There was a problem hiding this comment.
LGTM.
I have some further questions but I will resolve them via other channels.
lukemaurer
pushed a commit
that referenced
this pull request
Oct 23, 2024
…getting into signatures (#2827)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These cases have to do with destructive substitution and module alias types. When we expand an
Mty_aliasinto its definition, we must make the variables rigid if the new module type can be used to constrain something. To quote the tests:We should think a little harder about other ways this might happen - in particular other uses of
Typemod.extract_sigorMtype.scrape_alias. I've taken a quick scan, and will think about it some more (as the reviewer of this PR might do) but don't want to delay getting this PR in.This PR has three commits: