Fix issues in the tree related to Or_null#2808
Merged
dkalinichenko-js merged 9 commits intomainfrom Jul 19, 2024
Merged
Conversation
goldfirere
reviewed
Jul 17, 2024
goldfirere
approved these changes
Jul 19, 2024
Co-authored-by: Richard Eisenberg <reisenberg@janestreet.com>
lukemaurer
pushed a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Oct 23, 2024
…2808) * Probes are `value_or_null` * `Captured_in_object` variables can be null * fix build on macos? * fix mac os * comment * fix? * Update ocaml/typing/env.ml Co-authored-by: Richard Eisenberg <reisenberg@janestreet.com> * `not-macos` * wrong `not-macos` --------- Co-authored-by: Diana Kalinichenko <dkalinichenko@janestreet.com> Co-authored-by: Richard Eisenberg <reisenberg@janestreet.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
Probes and variablesCaptured_in_objectvalue_or_null.The check for probes happens too late to infer the right nullability for the jkind, so accept
or_nullfor backwards compatibility. Leave a CR to check that this is sound with null pointers.The check for captured variables similarly happens after generalizing variables in pattern matches on tuples. It should be fine to capture null pointers in objects, so do it.