Initial implementation of the Capsule API#2797
Merged
dkalinichenko-js merged 10 commits intomainfrom Jul 29, 2024
Merged
Conversation
lpw25
reviewed
Jul 19, 2024
Collaborator
lpw25
left a comment
There was a problem hiding this comment.
Looks good. A few comments, including one soundness issue we should fix and add tests for.
3eb1a42 to
986841d
Compare
lpw25
approved these changes
Jul 29, 2024
Collaborator
lpw25
left a comment
There was a problem hiding this comment.
A couple of small changes, then this is good to go
lukemaurer
pushed a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Oct 23, 2024
* draft implementation * Add to `Stdlib_alpha` * `portable` functions * tests * Enable tests only on runtime 5 * fixes * tests * Move annotations * `Ptr` -> `Data` * clarify what exceptions are caught --------- Co-authored-by: Diana Kalinichenko <dkalinichenko@janestreet.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the Capsule API per the design doc.
Password.ts are temporarilyvalues sincevoidcan't be used for function argument and return types yet. Mark every function in the interface asportable.Test the Capsule API. Since domains are not supported yet, behavior in presence of multiple threads is not tested.