Remove Stdlib_stable float32 modules in arm64 build#2770
Merged
Conversation
dkalinichenko-js
approved these changes
Jul 16, 2024
Collaborator
dkalinichenko-js
left a comment
There was a problem hiding this comment.
LGTM, though I think we can autogenerate the copying build rules. But let's do that later.
mshinwell
pushed a commit
to mshinwell/oxcaml
that referenced
this pull request
Aug 12, 2024
* make f32 modules amd64 only * format * update f32/simd tests to also only run on amd64 (cherry picked from commit 1dc9561)
lukemaurer
pushed a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Oct 23, 2024
oxcaml#2770) * make f32 modules amd64 only * format * update f32/simd tests to also only run on amd64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reshuffles
Stdlib_stableso that theFloat32andFloat32_umodules are not included on non-amd64 architectures.This should fix the arm64 build, @mshinwell can you check if it works?