Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
gasencounterscvtsi2sswhere the first (integer) operand is a memory location, it will assume that the int is 32 bits wide.Hence, we need to suffix the instruction name with the width of the integer operand.
This matches the usage of
cvtsi2sd.This bug does not apply to the internal assembler, which already cases on the operand width.
We believe it does not apply to the nasm assembler (no suffix was required for
cvtsi2sd), but nasm isn't tested, and isn't supported in flambda-backend anyway.(Bug found / fix tested in #2697)