Merged
Conversation
a857fae to
6ee5b3c
Compare
b1d8b95 to
2050d4b
Compare
1a55698 to
554474a
Compare
2050d4b to
2a9da51
Compare
goldfirere
reviewed
Jul 9, 2024
554474a to
fc4412c
Compare
Co-authored-by: Richard Eisenberg <reisenberg@janestreet.com>
24dec5e to
b0eeb13
Compare
goldfirere
approved these changes
Jul 17, 2024
* `Or_null` module * Tests --------- Co-authored-by: Diana Kalinichenko <dkalinichenko@janestreet.com>
jbachurski
added a commit
that referenced
this pull request
Aug 22, 2024
jbachurski
added a commit
that referenced
this pull request
Aug 22, 2024
ccasin
added a commit
that referenced
this pull request
Aug 22, 2024
lukemaurer
pushed a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Oct 23, 2024
* `or_null` predef * More tests * Gate `or_null` behind `Layouts Alpha` * Fix merge * Split and generalize `check_coherence` * Update ocaml/typing/typedecl.ml Co-authored-by: Richard Eisenberg <reisenberg@janestreet.com> * Accept tests * More tests * comments * object tests * `Stdlib_alpha.Or_null` (oxcaml#2751) * `Or_null` module * Tests --------- Co-authored-by: Diana Kalinichenko <dkalinichenko@janestreet.com> --------- Co-authored-by: Diana Kalinichenko <dkalinichenko@janestreet.com> Co-authored-by: Richard Eisenberg <reisenberg@janestreet.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not update the jkind in
update_decl_jkindif the manifest is available; always copy the manifest's jkind incheck_coherence. This allows us to give types like'a or_nullnon-standard jkinds for their kinds (i.e.value_or_nullforType_variant).Pre-define
or_nullwhenLayoutshas levelAlpha. Add tests foror_null.or_nullwill be added tostdlib_alphain the next PR.