Add (more) layout restrictions on unnamed values in the toplevel#2732
Merged
ccasin merged 5 commits intooxcaml:mainfrom Jul 18, 2024
Merged
Add (more) layout restrictions on unnamed values in the toplevel#2732ccasin merged 5 commits intooxcaml:mainfrom
ccasin merged 5 commits intooxcaml:mainfrom
Conversation
Collaborator
Author
|
Note this PR is conservative: We could allow these things in the bytecode toplevel but not in the nativecode toplevel. It doesn't seem worth the additional effort to thread that distinction to the right place, though, and in any event we expect these toplevels to behave similarly (there are tests for this). |
e74a266 to
78bfd9c
Compare
goldfirere
reviewed
Jun 26, 2024
ncik-roberts
approved these changes
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bans some uses of non-values in the toplevel, particularly
e;;andlet _ = e;;whene's type does not have layout value. Those cases currently hit an exception in the middle end, and have for a while - as unboxed types become more widely used we should give a nicer error, at least.There are a few ways to arrange for this - I'm not sure I've chosen the cleanest, but eventually we'll eliminate this restriction and this code will go away.
Review: @ncik-roberts perhaps?