Ghost regions etc. (new version of "Remove unnecessary regions for %int_as_pointer")#2682
Merged
mshinwell merged 14 commits intooxcaml:mainfrom Aug 9, 2024
Merged
Conversation
Gbury
reviewed
Jun 13, 2024
780cee8 to
c3dbac6
Compare
Ekdohibs
reviewed
Jul 18, 2024
Ekdohibs
reviewed
Jul 19, 2024
Ekdohibs
reviewed
Jul 19, 2024
42f1e2c to
a2e8521
Compare
6c1b5fa to
a4fd8c1
Compare
Ekdohibs
approved these changes
Aug 9, 2024
ITO444
pushed a commit
to ITO444/flambda-backend
that referenced
this pull request
Aug 13, 2024
…nt_as_pointer") (oxcaml#2682) Co-authored-by: Nathanaëlle Courant <nathanaelle.courant@ocamlpro.com>
lukemaurer
pushed a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Oct 23, 2024
…ry regions for %int_as_pointer") (oxcaml#2682) Co-authored-by: Nathanaëlle Courant <nathanaelle.courant@ocamlpro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new version of #2677 using the double region variable and ghost region approach. This seems to work pretty well, not least because it's shown up two concepts that I think were previously being conflated: these can be seen now as
Alloc_mode.For_applications.tandAlloc_mode.For_allocations.t.