Merged
Conversation
goldfirere
reviewed
Jun 19, 2024
Collaborator
goldfirere
left a comment
There was a problem hiding this comment.
Reviewed ocaml/testsuite/tests/typing-layouts/annots.ml, just to get things started. More to come.
goldfirere
reviewed
Jun 19, 2024
Collaborator
goldfirere
left a comment
There was a problem hiding this comment.
Finished reviewing testsuite changes
goldfirere
reviewed
Jun 20, 2024
ocaml/testsuite/tests/language-extensions/pprintast_unconditional.reference
Show resolved
Hide resolved
d09e34f to
4075e46
Compare
Merged
242be4c to
cfc857e
Compare
Contributor
Author
|
The first commit, 5d4918a ( |
5fd80b2 to
9940dc2
Compare
3251b32 to
948ccce
Compare
b62260f to
e21be2d
Compare
goldfirere
approved these changes
Aug 8, 2024
88bf2b9 to
1f5ca4e
Compare
1f5ca4e to
6c84274
Compare
Merged
lukemaurer
pushed a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Oct 23, 2024
* Promote tests that remove redundant kind from error message history * Rename Primitive to Builtin * Remove Const.Sort and Const.Layout aliases * Remove pointless const definition * Remove stale crs about eg layout_float64 * Remove legacy layout usage in printing * Remove legacy layout usage in extension universe check * Rename has_imported_history to is_imported * Remove Legacy module * Remove unused builtins * Move const_of_user_written_annotation into Const module * Update comment * Remove redundant layout definition * Remove unnecessary layout aliases * Document jkind printing * Rename ModeParser to Mode_parser * Fix cr formatting * Remove stale cr * Remove incorrect CRs * Replace any with abstract layout in error message * Assert layout is value in value_kind_of_value_jkind * Don't print : value * Add CRs to remove annotation * Improve debug printing * Share parsing logic between modes and jkinds * Simplify parsing * Add tests * Create test for not calling caml_modify * Reformat files * Add comments to caml_modify test * Rename external_record to internal_record * Hide external_variant's immediacy * Add inlining test for caml_modify * Add copyright header * Clean up typemodifier * Fix prining typo * Add CR to Builtin * Stop calling crossing of nullability mode-crossing * Improve warning 211 message * Restore PRs about incorrect error messages * Cleanup typemodifier more * Fix bug in required maturity level for modes * Fix floatarray kind and promote tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to write
modsyntax (ex:type t : value mod global). This PR also refactors Jkind so thatimmediate/immediate64is no longer a layout, but instead shorthand forvalue mod ....Reviewing note: The first two commits (
Promote tests that remove redundant kind from error message historyandRename Primitive to Builtin) have large, repetitive diffs. I recommend looking at them individually and then skipping them when looking at the total diff.