Display non_null_value as value#2613
Merged
dkalinichenko-js merged 8 commits intodkalinichenko/non_null_value_predefsfrom May 29, 2024
Merged
Display non_null_value as value#2613dkalinichenko-js merged 8 commits intodkalinichenko/non_null_value_predefsfrom
non_null_value as value#2613dkalinichenko-js merged 8 commits intodkalinichenko/non_null_value_predefsfrom
Conversation
goldfirere
approved these changes
May 24, 2024
fcb4f37 to
e213962
Compare
0fa1ec6 to
0fb138c
Compare
Collaborator
|
Is this ready to merge? Are you waiting for further review from me? After a rebase, it's hard to know what I've reviewed and what I haven't. So if you want further review, please ask (ideally with a commit range). If the little changes don't merit scrutiny, feel free to merge. |
dkalinichenko-js
added a commit
that referenced
this pull request
May 29, 2024
* `non_null_value_creation_reason` * Immediates are non-null * Primitives are non-null * Extensible variants are non-null * Boxed variants are non-null * Boxed records are non-null * Tuples are non-null * Polymorphic variants are non-null * Arrows are non-null * First-class modules are non-null * Basic tests * More tests * More tests * Leave `lazy_t` nullable for now * More basic tests * More tests * Format * Update ocaml/testsuite/tests/typing-layouts-non-null-value/basics.ml Co-authored-by: Richard Eisenberg <reisenberg@janestreet.com> * stable -> upstream_compatible * Update comments and tests * Display `non_null_value` as `value` (#2613) * Naive hack * Promote tests * More hacks * More hacks + promote tests * Test hiding * Stub `Or_null` module * Test sublayot error * Formatting --------- Co-authored-by: Diana Kalinichenko <dkalinichenko@janestreet.com> --------- Co-authored-by: Diana Kalinichenko <dkalinichenko@janestreet.com> Co-authored-by: Richard Eisenberg <reisenberg@janestreet.com>
lukemaurer
pushed a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Oct 23, 2024
* `non_null_value_creation_reason` * Immediates are non-null * Primitives are non-null * Extensible variants are non-null * Boxed variants are non-null * Boxed records are non-null * Tuples are non-null * Polymorphic variants are non-null * Arrows are non-null * First-class modules are non-null * Basic tests * More tests * More tests * Leave `lazy_t` nullable for now * More basic tests * More tests * Format * Update ocaml/testsuite/tests/typing-layouts-non-null-value/basics.ml Co-authored-by: Richard Eisenberg <reisenberg@janestreet.com> * stable -> upstream_compatible * Update comments and tests * Display `non_null_value` as `value` (oxcaml#2613) * Naive hack * Promote tests * More hacks * More hacks + promote tests * Test hiding * Stub `Or_null` module * Test sublayot error * Formatting --------- Co-authored-by: Diana Kalinichenko <dkalinichenko@janestreet.com> --------- Co-authored-by: Diana Kalinichenko <dkalinichenko@janestreet.com> Co-authored-by: Richard Eisenberg <reisenberg@janestreet.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Display
non_null_valueasvalueunless the extension universe is set toalpha.Still show
non_null_valueon 1) annotation errors 2) sublayout errors betweenvalueandnon_null_value.2 should be impossible to trigger without enabling alpha layouts. Create a stub for the
Or_nullmodule instdlib_alphafor testing this error.