Emit stack checks for probes#2539
Merged
xclerc merged 3 commits intostack-check-disablefrom May 7, 2024
Merged
Conversation
mshinwell
requested changes
May 7, 2024
mshinwell
approved these changes
May 7, 2024
xclerc
added a commit
that referenced
this pull request
May 7, 2024
xclerc
added a commit
that referenced
this pull request
May 9, 2024
* Disable stack checks by default. * Actually disable the checks. * Review * Make the build fail if stack checks are disabled but POSIX signals are not available. * Abort if trying to reallocate the stack when stack checks are disabled. * Emit stack checks for probes (#2539) * Force stack check to be enabled on arm64. * Make sure mmap and others are available when stack checks are disabled. * Correct arm64 check * Long line * Increase main stack size in case of getrlimit failure * Missing Wsize_bsize * Don't assume mmap returns a page-aligned block. * Ensure stack check are properly disabled on the non-CFG path. * Cosmetic changes; remove unnecessary label * Stack computations * Fix build. * Fix build. --------- Co-authored-by: Mark Shinwell <mshinwell@pm.me>
gretay-js
pushed a commit
to gretay-js/flambda-backend
that referenced
this pull request
May 13, 2024
* Disable stack checks by default. * Actually disable the checks. * Review * Make the build fail if stack checks are disabled but POSIX signals are not available. * Abort if trying to reallocate the stack when stack checks are disabled. * Emit stack checks for probes (oxcaml#2539) * Force stack check to be enabled on arm64. * Make sure mmap and others are available when stack checks are disabled. * Correct arm64 check * Long line * Increase main stack size in case of getrlimit failure * Missing Wsize_bsize * Don't assume mmap returns a page-aligned block. * Ensure stack check are properly disabled on the non-CFG path. * Cosmetic changes; remove unnecessary label * Stack computations * Fix build. * Fix build. --------- Co-authored-by: Mark Shinwell <mshinwell@pm.me>
gretay-js
pushed a commit
to gretay-js/flambda-backend
that referenced
this pull request
May 13, 2024
* Disable stack checks by default. * Actually disable the checks. * Review * Make the build fail if stack checks are disabled but POSIX signals are not available. * Abort if trying to reallocate the stack when stack checks are disabled. * Emit stack checks for probes (oxcaml#2539) * Force stack check to be enabled on arm64. * Make sure mmap and others are available when stack checks are disabled. * Correct arm64 check * Long line * Increase main stack size in case of getrlimit failure * Missing Wsize_bsize * Don't assume mmap returns a page-aligned block. * Ensure stack check are properly disabled on the non-CFG path. * Cosmetic changes; remove unnecessary label * Stack computations * Fix build. * Fix build. --------- Co-authored-by: Mark Shinwell <mshinwell@pm.me>
lukemaurer
pushed a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Oct 23, 2024
* Disable stack checks by default. * Actually disable the checks. * Review * Make the build fail if stack checks are disabled but POSIX signals are not available. * Abort if trying to reallocate the stack when stack checks are disabled. * Emit stack checks for probes (oxcaml#2539) * Force stack check to be enabled on arm64. * Make sure mmap and others are available when stack checks are disabled. * Correct arm64 check * Long line * Increase main stack size in case of getrlimit failure * Missing Wsize_bsize * Don't assume mmap returns a page-aligned block. * Ensure stack check are properly disabled on the non-CFG path. * Cosmetic changes; remove unnecessary label * Stack computations * Fix build. * Fix build. --------- Co-authored-by: Mark Shinwell <mshinwell@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request add the emission of
stack checks in probes. Since a probe
will save on the stack all the hardware
registers that happen to be live, it
seems possible to have to push more
data than
stack_threshold_sizeallows.