Conversation
d83be31 to
8ade880
Compare
mshinwell
approved these changes
May 9, 2024
Collaborator
mshinwell
left a comment
There was a problem hiding this comment.
Please try to avoid single-letter variable names where there is an obvious alternative!
TheNumbat
commented
May 9, 2024
| let dacc = DA.add_variable dacc result_var ty in | ||
| SPR.create original_term ~try_reify:true dacc | ||
| | Known_result _ | Need_meet -> | ||
| SPR.create_unknown dacc ~result_var K.naked_float ~original_term |
Member
Author
There was a problem hiding this comment.
The K.naked_float also needs to be parameterized here - fixing in #2385
gretay-js
pushed a commit
to gretay-js/flambda-backend
that referenced
this pull request
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds arithmetic operations for
float32in the middle end; again cuts off at the CMM implementations.Following PR adds backend support.