Copy Import_info as Import_info.Intf and Import_info.Impl#1933
Closed
lukemaurer wants to merge 7 commits intooxcaml:mainfrom
Closed
Copy Import_info as Import_info.Intf and Import_info.Impl#1933lukemaurer wants to merge 7 commits intooxcaml:mainfrom
Import_info as Import_info.Intf and Import_info.Impl#1933lukemaurer wants to merge 7 commits intooxcaml:mainfrom
Conversation
PR oxcaml#1746 will change the APIs and implementations to reflect the differences in the datatypes. (Currently, the major difference is that an `Impl.t` always has a full compilation unit, but parameterised libraries will add more differences.)
Contributor
Author
|
Converting to draft, as this work may be getting rolled into #1753 . |
Contributor
Author
(or at any rate this PR's direction may be influenced by that one) |
lukemaurer
added a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Apr 30, 2024
[Import_info.t] is now split between the intf and impl cases, which will make it easier for a subsequent PR (which will likely supersede oxcaml#1746 and oxcaml#1933) to pull apart the types and force all callers to choose. Also added a [Consistbl]-centric API for each of [Intf] and [Impl] to make it easy again to convert between import info and an entry in a [Consistbl].
Contributor
Author
|
Superseded by #2552. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1746 will change the APIs and implementations to reflect the differences in the datatypes. (Currently, the major difference is that an
Impl.talways has a full compilation unit, but parameterised libraries will add more differences.)