Improve layout history error message: change message wording and add more tests#1877
Merged
alanechang merged 8 commits intoaec/better-msg-on-value-defaultfrom Oct 2, 2023
Conversation
Contributor
alanechang
commented
Sep 28, 2023
- Changes the wording of the Imported layout reason
- Fixes a few unnecessary uppercase words
- Adds more tests with the goal of getting full coverage of all possible layout history message snippets
goldfirere
approved these changes
Sep 28, 2023
Collaborator
goldfirere
left a comment
There was a problem hiding this comment.
Just a few tweaks suggested. Feel free to merge once the changes are made. Thanks!
3e57851 to
75caf83
Compare
f3890f8 to
0cb571b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.