Merged
Conversation
Contributor
|
I find the "backend_impl" situation a bit confusing: the library is Should we consider renaming the directory? (Maybe even to the |
Merged
xclerc
approved these changes
Jul 23, 2021
Contributor
xclerc
left a comment
There was a problem hiding this comment.
#106 (comment) is optional.
Collaborator
Author
|
I'll deal with the |
mshinwell
added a commit
to mshinwell/oxcaml
that referenced
this pull request
Aug 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the necessary changes to
Asmpackagerfor Flambda 2. To avoid circular dependencies, the Flambda 2 middle end and Flambda 2 to Cmm translation aren't referenced until right at the top, inFlambda_backend_main.This PR also fixes the misnaming of the
Flambda_backend_impllibrary (although this still doesn't solve the problem of needing to use the mangled names).