chore: update typescript-go submodule#955
Merged
graphite-app[bot] merged 1 commit intoMay 15, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the TypeScript-Go integration by refreshing generated shim exports, patch metadata, and workspace dependency checksums for a newer upstream submodule revision.
Changes:
- Adds regenerated checker and ast shim symbols for newly exposed upstream APIs.
- Refreshes patch stack commit headers against the new upstream base.
- Updates
go.work.sumwith dependency checksums pulled in by the new workspace state.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
shim/checker/shim.go |
Adds checker mirror field and re-exports new ExternalEmitHelpers symbols. |
shim/ast/shim.go |
Adds linkname declarations for new ast helper functions. |
patches/0001-Adapt-project-service-for-single-run-mode.patch |
Refreshes patch header commit hash. |
patches/0002-patch-expose-more-functions-via-the-shim-with-type-f.patch |
Refreshes patch header commit hash. |
patches/0003-fix-early-return-from-invalid-tsconfig-for-better-er.patch |
Refreshes patch header commit hash. |
patches/0004-fix-collections-avoid-internal-json-import-in-ordere.patch |
Refreshes patch header commit hash. |
patches/0005-perf-vfs-cache-ReadFile-results-in-cachedvfs.patch |
Refreshes patch header commit hash. |
go.work.sum |
Adds workspace checksum entries for dependencies from the updated TypeScript-Go workspace. |
Files not reviewed (2)
- shim/ast/shim.go: Language not supported
- shim/checker/shim.go: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
Merge activity
|
## Summary - Update the `typescript-go` submodule from `092b34f534182baf2875887c20ffed2177f14d92` to `c282336ea94f8a2e63187afd0f8d4bfb3b3f4d3b` - Refresh the existing `patches/*.patch` stack against the new upstream base - Regenerate shims for new upstream exported symbols and update `go.work.sum` - Update root and shim module pins to `github.com/microsoft/typescript-go v0.0.0-20260514231437-c282336ea94f` ## Testing - `go test ./internal/...` - `go build -buildvcs=false -o /private/tmp/tsgolint-build-check ./cmd/tsgolint` Note: local `just build` failed before compilation because Go attempted VCS stamping from `/Users/cameron` in this worktree; the same build passed with `-buildvcs=false`. The tests above were run against the patched submodule state, matching CI setup.
da0e862 to
c914633
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typescript-gosubmodule from092b34f534182baf2875887c20ffed2177f14d92toc282336ea94f8a2e63187afd0f8d4bfb3b3f4d3bpatches/*.patchstack against the new upstream basego.work.sumgithub.com/microsoft/typescript-go v0.0.0-20260514231437-c282336ea94fTesting
go test ./internal/...go build -buildvcs=false -o /private/tmp/tsgolint-build-check ./cmd/tsgolintNote: local
just buildfailed before compilation because Go attempted VCS stamping from/Users/cameronin this worktree; the same build passed with-buildvcs=false. The tests above were run against the patched submodule state, matching CI setup.