fix(no-useless-default-assignment): make default assignment removal a suggestion#907
Merged
graphite-app[bot] merged 1 commit intoApr 24, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Updates no-useless-default-assignment to emit a fix as a suggestion (instead of an auto-applied fix), aligning with the goal of “suggest default assignment removal” for oxc-project/oxc#21716.
Changes:
- Switch
uselessDefaultAssignmentreporting fromFixesPtrtoReportDiagnosticWithSuggestions, attaching aremoveDefaultAssignmentsuggestion. - Update rule tester cases to assert suggestions (instead of
Outputauto-fix expectations) foruselessDefaultAssignment. - Refresh rule-tester and e2e snapshots to reflect the new suggestions structure.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/rules/no_useless_default_assignment/no_useless_default_assignment.go | Reports uselessDefaultAssignment with a removal suggestion rather than an auto-fix. |
| internal/rules/no_useless_default_assignment/no_useless_default_assignment_test.go | Migrates affected invalid test cases from Output to Suggestions. |
| internal/rule_tester/snapshots/no-useless-default-assignment.snap | Snapshot updates to include suggestion rendering. |
| e2e/snapshots/snapshot.test.ts.snap | E2E snapshot updates: diagnostic fixes moved under suggestions[].fixes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
Merge activity
|
… suggestion (#907) Fixes oxc-project/oxc#21716 Although this being a fix aligns with the type system, it could technically break users if their runtime values don't match their typescript types.
3477f56 to
05314ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes oxc-project/oxc#21716
Although this being a fix aligns with the type system, it could technically break users if their runtime values don't match their typescript types.