chore: update typescript-go submodule#905
Merged
graphite-app[bot] merged 1 commit intoApr 24, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the vendored typescript-go submodule and refreshes this repo’s compatibility layer (patch series + generated shims) to match upstream API changes.
Changes:
- Bump
typescript-gosubmodule and refreshpatches/*.patchagainst the new upstream base. - Regenerate shim exports for updated upstream surfaces (checker, lsproto, tsoptions).
- Update workspace dependency checksums in
go.work.sum.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| shim/tsoptions/shim.go | Removes a shim export (InverseJsxOptionMap) to match upstream surface changes. |
| shim/lsp/lsproto/shim.go | Updates LSP protocol shim aliases/constants (removes closing tag completion, adds multi-document highlight + VS auto-insert). |
| shim/checker/shim.go | Exposes newly added checker flags via shim constants. |
| patches/0001-Adapt-project-service-for-single-run-mode.patch | Patch series metadata refreshed for new upstream base. |
| patches/0002-patch-expose-more-functions-via-the-shim-with-type-f.patch | Patch series metadata refreshed for new upstream base. |
| patches/0003-fix-early-return-from-invalid-tsconfig-for-better-er.patch | Patch series metadata refreshed for new upstream base. |
| patches/0004-fix-collections-avoid-internal-json-import-in-ordere.patch | Patch series metadata refreshed for new upstream base. |
| patches/0005-perf-vfs-cache-ReadFile-results-in-cachedvfs.patch | Patch series metadata refreshed for new upstream base. |
| go.work.sum | Workspace checksum updates; currently missing sums for some versions pinned in go.mod. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
Merge activity
|
## Summary - update the `typescript-go` submodule from `83b8d2aa23b2d385087dabe5a5a8afd5e296013d` to `ba858e5c6852160ff69184d7fd7db77b348e246c` - refresh the local `patches/*.patch` series against the new upstream base - regenerate shims for upstream API surface changes in checker, lsproto, and tsoptions ## Verification - `just shim` - `go test ./internal/...` against the refreshed patched submodule state - CI workflows apply `patches/*.patch` before build/test via `.github/actions/setup`
c901d43 to
dbfba7b
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typescript-gosubmodule from83b8d2aa23b2d385087dabe5a5a8afd5e296013dtoba858e5c6852160ff69184d7fd7db77b348e246cpatches/*.patchseries against the new upstream baseVerification
just shimgo test ./internal/...against the refreshed patched submodule statepatches/*.patchbefore build/test via.github/actions/setup