chore: update typescript-go submodule#895
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the vendored typescript-go submodule snapshot and refreshes the local patch stack + generated shim surface so tsgolint stays compatible with upstream API/signature changes (notably around config registry building, snapshotfs, and core allocation primitives).
Changes:
- Regenerated/updated shim exports to match upstream removals/additions (e.g.,
Arena, semaphores, alias helpers, updated builder signatures). - Refreshed
patches/*.patchseries against the new submodule revision and added patch 0006 for exportingRealpathAliasSet+ updating the snapshotfs builder helper signature. - Updated local resolver/test fixtures for the updated config registry builder signature and checkJs fixture discovery.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| shim/project/shim.go | Updates go:linkname signatures/aliases for NewConfigFileRegistryBuilder, NewSnapshotFSBuilder, and exports new project types. |
| shim/lsp/lsproto/shim.go | Removes shim exposure of ResolveClientCapabilities (no longer needed/available). |
| shim/core/shim.go | Adds new core exports (Arena, semaphores) and removes Pool shim export. |
| shim/checker/shim.go | Aligns checker internal fields with upstream change from pools to arenas; adds new flags/types. |
| shim/ast/shim.go | Removes obsolete CommonJS/ExportAssignment alias helpers and adds new/renamed AST helpers/constants. |
| internal/utils/find_tsconfig.go | Adapts NewConfigFileRegistryBuilder callsite to new signature by passing the new capability boolean. |
| internal/rules/fixtures/repro.js | Adds a JS fixture used by checkJs-related rule tests. |
| patches/README.md | Documents the new patch 0006 purpose in the patch stack notes. |
| patches/0001-Adapt-project-service-for-single-run-mode.patch | Patch header refreshed for new 6-patch stack. |
| patches/0002-patch-expose-more-functions-via-the-shim-with-type-f.patch | Patch header refreshed for new 6-patch stack. |
| patches/0003-fix-early-return-from-invalid-tsconfig-for-better-er.patch | Patch header refreshed for new 6-patch stack. |
| patches/0004-fix-collections-avoid-internal-json-import-in-ordere.patch | Patch header refreshed for new 6-patch stack. |
| patches/0005-perf-vfs-cache-ReadFile-results-in-cachedvfs.patch | Patch header refreshed for new 6-patch stack. |
| patches/0006-fix-project-export-realpath-alias-set-for-shim-snaps.patch | New patch exporting RealpathAliasSet and updating TSGolint snapshotfs builder helper call. |
| go.work.sum | Updates module sums consistent with the refreshed dependency graph after submodule update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
Merge activity
|
## Summary - update the `typescript-go` submodule from `886e854df8e86e2dda3f3a2518e5226f3cafcecc` to `83b8d2aa23b2d385087dabe5a5a8afd5e296013d` - refresh the local `patches/*.patch` series against the new upstream base, keeping the shim snapshotfs export changes folded into `0002` - regenerate shims and update TSGolint compatibility for the new builder signature ## Verification - `go test ./internal/...` against the refreshed patched submodule state - `just test` against the refreshed patched submodule state - CI workflows apply `patches/*.patch` before build/test via `.github/actions/setup`
565e483 to
b729345
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typescript-gosubmodule from886e854df8e86e2dda3f3a2518e5226f3cafceccto83b8d2aa23b2d385087dabe5a5a8afd5e296013dpatches/*.patchseries against the new upstream base, keeping the shim snapshotfs export changes folded into0002Verification
go test ./internal/...against the refreshed patched submodule statejust testagainst the refreshed patched submodule statepatches/*.patchbefore build/test via.github/actions/setup