chore: update typescript-go submodule#873
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the typescript-go submodule baseline and refreshes this repo’s shim/patch integration to match upstream API and type surface changes.
Changes:
- Regenerates/updates shim exports to match upstream symbol/type changes (project, compiler, lsproto).
- Updates
find_tsconfigto use the newNewConfigFileRegistryBuildersignature (addssnapshotIDargument). - Refreshes the
patches/*.patchseries metadata against the new upstream base.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
shim/project/shim.go |
Adjusts shimmed project APIs/types for upstream signature/generic changes. |
shim/lsp/lsproto/shim.go |
Updates LSP protocol shim surface (drops notebook-related items, adds missing semantic tokens method constant, updates type aliases). |
shim/compiler/shim.go |
Exposes newly available upstream compiler type via shim. |
internal/utils/find_tsconfig.go |
Adapts resolver construction to the updated NewConfigFileRegistryBuilder signature. |
patches/0001-Adapt-project-service-for-single-run-mode.patch |
Refreshes patch header to new upstream base commit. |
patches/0002-patch-expose-more-functions-via-the-shim-with-type-f.patch |
Refreshes patch header to new upstream base commit. |
patches/0003-fix-early-return-from-invalid-tsconfig-for-better-er.patch |
Refreshes patch header to new upstream base commit. |
patches/0004-fix-collections-avoid-internal-json-import-in-ordere.patch |
Refreshes patch header to new upstream base commit. |
patches/0005-perf-vfs-cache-ReadFile-results-in-cachedvfs.patch |
Refreshes patch header to new upstream base commit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
Merge activity
|
## Summary - update the `typescript-go` submodule from `025d5aa3913ad54c5eae6be37677d3b85f783fd9` to `c0703e66b68b826eedadce353d63fe9f4ea21fb6` - refresh the local `patches/*.patch` series against the new upstream base - regenerate shims and update `find_tsconfig` for the `NewConfigFileRegistryBuilder` signature change ## Verification - `go test ./internal/...` against the refreshed patched submodule state - CI workflows apply `patches/*.patch` before build/test via `.github/actions/setup`
68d3e21 to
588ec3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typescript-gosubmodule from025d5aa3913ad54c5eae6be37677d3b85f783fd9toc0703e66b68b826eedadce353d63fe9f4ea21fb6patches/*.patchseries against the new upstream basefind_tsconfigfor theNewConfigFileRegistryBuildersignature changeVerification
go test ./internal/...against the refreshed patched submodule statepatches/*.patchbefore build/test via.github/actions/setup