perf: use simd optimzed json string escape impl by Brooooooklyn · Pull Request #158 · oxc-project/oxc-sourcemap

Brooooooklyn · 2025-09-23T08:06:36Z

benchmark results on GitHub actions runner: https://docs.rs/json-escape-simd/latest/json_escape_simd/

GitHub Actions x86_64 (`ubuntu-latest`)

AVX2 enabled.

RxJS payload (~10k iterations)

Implementation	Median time	vs fastest
`escape simd`	345.06 µs	1.00×
`escape v_jsonescape`	576.25 µs	1.67×
`escape generic`	657.94 µs	1.91×
`serde_json`	766.72 µs	2.22×
`json-escape`	782.65 µs	2.27×

Escape AFFiNE sources (~300 iterations)

Implementation	Median time	vs fastest
`escape simd`	12.84 ms	1.00×
`escape v_jsonescape`	19.66 ms	1.53×
`escape generic`	22.53 ms	1.75×
`serde_json`	24.65 ms	1.92×
`json-escape`	26.64 ms	2.07×

Brooooooklyn · 2025-09-23T08:06:59Z

perf: use simd optimzed json string escape impl #158 👈 (View in Graphite)
build: enable fat lto in bench profile #161
main

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-09-23T08:09:19Z

CodSpeed Performance Report

Merging #158 will degrade performances by 7.69%

_{Comparing 09-23-perf_use_simd_optimzed_json_string_escape_impl (4a76d74) with main (e6aa0cd)}

Summary

⚡ 1 improvement
❌ 2 (👁 1) regressions
✅ 2 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	`BASE`	`HEAD`	Change
⚡	`generate_lookup_table`	1.3 µs	1.3 µs	+4.59%
❌	`to_json`	5.6 µs	5.6 µs	-1.04%
👁	`to_json_string`	6.3 µs	6.9 µs	-7.69%

Brooooooklyn · 2025-09-23T09:42:53Z

I can see 2% - 4% performance boost (10 times run) on my Linux WSL in apps/10000 rolldown benchmark with sourceMap: true option

❯ hyperfine -n json-escape-simd "node ../../../rolldown/packages/rolldown/dist/cli.mjs build --config rolldown.config.mjs" -n main "node ../../node_
modules/rolldown/dist/cli.mjs build --config rolldown.config.mjs"
Benchmark 1: json-escape-simd
  Time (mean ± σ):      1.527 s ±  0.096 s    [User: 2.914 s, System: 1.349 s]
  Range (min … max):    1.427 s …  1.681 s    10 runs
 
Benchmark 2: main
  Time (mean ± σ):      1.585 s ±  0.098 s    [User: 2.903 s, System: 1.523 s]
  Range (min … max):    1.438 s …  1.707 s    10 runs
 
Summary
  'json-escape-simd' ran
    1.04 ± 0.09 times faster than 'main'

Boshen · 2025-09-23T10:24:36Z

CodSpeed Performance Report

Merging #158 will degrade performances by 10.35%

Comparing 09-23-perf_use_simd_optimzed_json_string_escape_impl (247341d) with main (71b57ff)

Summary

❌ 3 regressions ✅ 2 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ generate_lookup_table 1.5 µs 1.6 µs -7.17%
❌ to_json 6.2 µs 6.3 µs -1.84%
❌ to_json_string 7.1 µs 7.9 µs -10.35%

There's probably an allocation somewhere?

Brooooooklyn · 2025-09-23T11:17:20Z

There's probably an allocation somewhere?

You are absolutely right!

Boshen · 2025-09-23T14:43:32Z

Merge activity

Sep 23, 2:43 PM UTC: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 23, 2:43 PM UTC: Boshen added this pull request to the Graphite merge queue.
Sep 23, 2:45 PM UTC: Merged by the Graphite merge queue.

benchmark results on GitHub actions runner: https://docs.rs/json-escape-simd/latest/json_escape_simd/ ### GitHub Actions x86_64 (`ubuntu-latest`) `AVX2` enabled. **RxJS payload (~10k iterations)** | Implementation | Median time | vs fastest | | --------------------- | ------------- | ---------- | | **`escape simd`** | **345.06 µs** | **1.00×** | | `escape v_jsonescape` | 576.25 µs | 1.67× | | `escape generic` | 657.94 µs | 1.91× | | `serde_json` | 766.72 µs | 2.22× | | `json-escape` | 782.65 µs | 2.27× | **Escape AFFiNE sources (~300 iterations)** | Implementation | Median time | vs fastest | | --------------------- | ------------ | ---------- | | **`escape simd`** | **12.84 ms** | **1.00×** | | `escape v_jsonescape` | 19.66 ms | 1.53× | | `escape generic` | 22.53 ms | 1.75× | | `serde_json` | 24.65 ms | 1.92× | | `json-escape` | 26.64 ms | 2.07× |

…test (#6317) * oxc-project/oxc-sourcemap#158 * oxc-project/oxc-sourcemap#163 * oxc-project/oxc-resolver#727 (fixes memory leak)

Brooooooklyn marked this pull request as ready for review September 23, 2025 08:20

Brooooooklyn force-pushed the 09-23-perf_use_simd_optimzed_json_string_escape_impl branch from 2a4368c to 90dff02 Compare September 23, 2025 09:18

Brooooooklyn force-pushed the 09-23-perf_use_simd_optimzed_json_string_escape_impl branch from 90dff02 to 247341d Compare September 23, 2025 09:50

Brooooooklyn force-pushed the 09-23-perf_use_simd_optimzed_json_string_escape_impl branch from 247341d to 04003cd Compare September 23, 2025 11:11

Brooooooklyn mentioned this pull request Sep 23, 2025

perf: use simd optimzed json string escape impl #159

Closed

Brooooooklyn force-pushed the 09-23-perf_use_simd_optimzed_json_string_escape_impl branch from 04003cd to 54e2a99 Compare September 23, 2025 12:01

Brooooooklyn mentioned this pull request Sep 23, 2025

perf: use simd optimzed json string escape impl #160

Closed

Brooooooklyn changed the base branch from main to graphite-base/158 September 23, 2025 13:04

Brooooooklyn force-pushed the 09-23-perf_use_simd_optimzed_json_string_escape_impl branch from 54e2a99 to 5034b21 Compare September 23, 2025 13:04

Brooooooklyn changed the base branch from graphite-base/158 to 09-23-build_enable_fat_lto_in_bench_profile September 23, 2025 13:04

Brooooooklyn mentioned this pull request Sep 23, 2025

build: enable fat lto in bench profile #161

Merged

graphite-app bot changed the base branch from 09-23-build_enable_fat_lto_in_bench_profile to graphite-base/158 September 23, 2025 13:44

graphite-app bot force-pushed the graphite-base/158 branch from 97cb467 to e6aa0cd Compare September 23, 2025 13:46

graphite-app bot force-pushed the 09-23-perf_use_simd_optimzed_json_string_escape_impl branch from ea7500d to 8ab2f7b Compare September 23, 2025 13:46

graphite-app bot changed the base branch from graphite-base/158 to main September 23, 2025 13:47

graphite-app bot force-pushed the 09-23-perf_use_simd_optimzed_json_string_escape_impl branch from 8ab2f7b to dde55a1 Compare September 23, 2025 13:47

Brooooooklyn force-pushed the 09-23-perf_use_simd_optimzed_json_string_escape_impl branch from dde55a1 to f7848a6 Compare September 23, 2025 14:04

Boshen added the merge label Sep 23, 2025

graphite-app bot force-pushed the 09-23-perf_use_simd_optimzed_json_string_escape_impl branch from 06a925c to 4a76d74 Compare September 23, 2025 14:43

graphite-app bot merged commit 4a76d74 into main Sep 23, 2025
8 checks passed

graphite-app bot deleted the 09-23-perf_use_simd_optimzed_json_string_escape_impl branch September 23, 2025 14:45

graphite-app bot removed the merge label Sep 23, 2025

Boshen mentioned this pull request Sep 23, 2025

chore: release v4.1.3 #162

Merged

Boshen mentioned this pull request Sep 24, 2025

chore(deps): bump oxc-resolver, oxc-sourcemap, oxc-browserslist to latest rolldown/rolldown#6317

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

perf: use simd optimzed json string escape impl#158

perf: use simd optimzed json string escape impl#158
graphite-app[bot] merged 1 commit intomainfrom
09-23-perf_use_simd_optimzed_json_string_escape_impl

Brooooooklyn commented Sep 23, 2025 •

edited

Loading

Uh oh!

Brooooooklyn commented Sep 23, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Sep 23, 2025 •

edited

Loading

Uh oh!

Brooooooklyn commented Sep 23, 2025

Uh oh!

Boshen commented Sep 23, 2025

CodSpeed Performance Report

Merging #158 will degrade performances by 10.35%

Summary

Benchmarks breakdown

Uh oh!

Brooooooklyn commented Sep 23, 2025

Uh oh!

Boshen commented Sep 23, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Brooooooklyn commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GitHub Actions x86_64 (ubuntu-latest)

Uh oh!

Brooooooklyn commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #158 will degrade performances by 7.69%

Summary

Benchmarks breakdown

Uh oh!

Brooooooklyn commented Sep 23, 2025

Uh oh!

Boshen commented Sep 23, 2025

CodSpeed Performance Report

Merging #158 will degrade performances by 10.35%

Summary

Benchmarks breakdown

Uh oh!

Brooooooklyn commented Sep 23, 2025

Uh oh!

Boshen commented Sep 23, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Brooooooklyn commented Sep 23, 2025 •

edited

Loading

GitHub Actions x86_64 (`ubuntu-latest`)

Brooooooklyn commented Sep 23, 2025 •

edited

Loading

codspeed-hq bot commented Sep 23, 2025 •

edited

Loading

Boshen commented Sep 23, 2025 •

edited by graphite-app bot

Loading