Skip to content

feat: allow subpath imports that start with #/#907

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-05-feat_allow_subpath_imports_that_start_with__
Dec 5, 2025
Merged

feat: allow subpath imports that start with #/#907
graphite-app[bot] merged 1 commit intomainfrom
12-05-feat_allow_subpath_imports_that_start_with__

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Dec 5, 2025

closes #904

This opens up the door to symmetric exports and imports:

package.json:

{
  "exports": {
    "./*": "./src/*"
  },
  "imports": {
    "#/*": "./src/*"
  }
}

@Boshen Graphite App
Copy link
Member Author

Boshen commented Dec 5, 2025

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app
Copy link

graphite-app bot commented Dec 5, 2025 •
edited
Loading

Merge activity

@Boshen
feat: allow subpath imports that start with #/ (#907)
4e19df7 
closes #904

This opens up the door to symmetric `exports` and `imports`:

package.json:

```
{
  "exports": {
    "./*": "./src/*"
  },
  "imports": {
    "#/*": "./src/*"
  }
}
```
@graphite-app graphite-app bot force-pushed the 12-05-feat_allow_subpath_imports_that_start_with__ branch from 751565c to 4e19df7 Compare December 5, 2025 03:58
@codecov
Copy link

codecov bot commented Dec 5, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.41%. Comparing base (845e8c8) to head (4e19df7).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #907   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files          17       17           
  Lines        3315     3315           
=======================================
  Hits         3130     3130           
  Misses        185      185

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graphite-app graphite-app bot merged commit 4e19df7 into main Dec 5, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 12-05-feat_allow_subpath_imports_that_start_with__ branch December 5, 2025 04:01
@Boshen Boshen mentioned this pull request Dec 5, 2025
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 5, 2025

CodSpeed Performance Report

Merging #907 will degrade performances by 7.87%

Comparing 12-05-feat_allow_subpath_imports_that_start_with__ (4e19df7) with main (845e8c8)1

Summary

⚡ 1 improvement
❌ 1 regression
✅ 10 untouched
⏩ 5 skipped2

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ small 10.8 µs 11.8 µs -7.87%
⚡ resolver_real[multi-thread] 490.8 µs 474.8 µs +3.37%

Footnotes

  1. No successful run was found on main (4e19df7) during the generation of this report, so 845e8c8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@hybrist hybrist mentioned this pull request Dec 11, 2025
Open
24 tasks
@Boshen Boshen mentioned this pull request Dec 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

allow subpath imports that start with #/

1 participant

@Boshen