Skip to content

refactor: remove redundant PathBuf storage in CachedPath#891

Merged
Boshen merged 1 commit into
mainfrom
refactor/remove-redundant-pathbuf-in-cached-path
Dec 1, 2025
Merged

refactor: remove redundant PathBuf storage in CachedPath#891
Boshen merged 1 commit into
mainfrom
refactor/remove-redundant-pathbuf-in-cached-path

Conversation

@Boshen

@Boshen Boshen commented Dec 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • Remove redundant PathBuf storage from parent and node_modules fields in CachedPathImpl
  • Derive parent and node_modules paths on-demand from the base path when needed
  • Reduces memory overhead by eliminating two PathBuf allocations per CachedPath instance

@Boshen @claude
refactor: remove redundant PathBuf storage in CachedPath
3d6928d 
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@graphite-app

graphite-app Bot commented Dec 1, 2025

Copy link
Copy Markdown

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov

codecov Bot commented Dec 1, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.38%. Comparing base (f4f71d4) to head (3d6928d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #891      +/-   ##
==========================================
- Coverage   94.38%   94.38%   -0.01%     
==========================================
  Files          17       17              
  Lines        3244     3243       -1     
==========================================
- Hits         3062     3061       -1     
  Misses        182      182

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq

codspeed-hq Bot commented Dec 1, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #891 will improve performances by 3.43%

Comparing refactor/remove-redundant-pathbuf-in-cached-path (3d6928d) with main (d6a1e1f)

Summary

⚡ 1 improvement
✅ 11 untouched
⏩ 5 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ resolver_memory[find tsconfig] 14.3 µs 13.9 µs +3.43%

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Boshen Boshen merged commit a1d806b into main Dec 1, 2025
18 checks passed
@Boshen Boshen deleted the refactor/remove-redundant-pathbuf-in-cached-path branch December 1, 2025 09:50
@Boshen Boshen mentioned this pull request Dec 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Boshen