Skip to content

refactor: remove the redundant inner_resolver from load_pnp#862

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-22-refactor_remove_the_redundant_inner_resolver_from_load_pnp_
Nov 22, 2025
Merged

refactor: remove the redundant inner_resolver from load_pnp#862
graphite-app[bot] merged 1 commit intomainfrom
11-22-refactor_remove_the_redundant_inner_resolver_from_load_pnp_

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Nov 22, 2025

No description provided.

@Boshen Graphite App
Copy link
Member Author

Boshen commented Nov 22, 2025

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Nov 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.00%. Comparing base (5d69d24) to head (39ca611).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #862   +/-   ##
=======================================
  Coverage   94.00%   94.00%           
=======================================
  Files          17       17           
  Lines        2987     2987           
=======================================
  Hits         2808     2808           
  Misses        179      179

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 22, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #862 will improve performances by 3.15%

Comparing 11-22-refactor_remove_the_redundant_inner_resolver_from_load_pnp_ (39ca611) with main (5d69d24)1

Summary

⚡ 1 improvement
✅ 10 untouched
⏩ 5 skipped2

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ resolver_real[multi-thread] 489.2 µs 474.2 µs +3.15%

Footnotes

  1. No successful run was found on main (39ca611) during the generation of this report, so 5d69d24 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Boshen Boshen force-pushed the 11-22-refactor_remove_the_redundant_inner_resolver_from_load_pnp_ branch from 509bfb8 to d883769 Compare November 22, 2025 16:22
@graphite-app
Copy link

graphite-app bot commented Nov 22, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 11-22-refactor_remove_the_redundant_inner_resolver_from_load_pnp_ branch from d883769 to 39ca611 Compare November 22, 2025 16:30
@graphite-app graphite-app bot merged commit 39ca611 into main Nov 22, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 11-22-refactor_remove_the_redundant_inner_resolver_from_load_pnp_ branch November 22, 2025 16:33
This was referenced Nov 22, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Boshen