Skip to content

feat: add .d.ts resolver#502

Closed
Boshen wants to merge 2 commits intomainfrom
05-06-feat_add_resolve_dts_api_for_resolving_.d.ts_files
Closed

feat: add .d.ts resolver#502
Boshen wants to merge 2 commits intomainfrom
05-06-feat_add_resolve_dts_api_for_resolving_.d.ts_files

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented May 6, 2025

resolves #113
related #493

@Boshen Boshen requested a review from sxzz May 6, 2025 11:32
@Boshen Boshen changed the title feat: add resolve_dts API for resolving .d.ts files feat: add resolve_package_dts API for resolving .d.ts files for a node_modules package May 6, 2025
@codecov
Copy link

codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.52381% with 13 lines in your changes missing coverage. Please review.

Project coverage is 93.57%. Comparing base (cae2beb) to head (0af0463).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/lib.rs 84.52% 13 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
- Coverage   93.85%   93.57%   -0.28%     
==========================================
  Files          13       13              
  Lines        2797     2880      +83     
==========================================
+ Hits         2625     2695      +70     
- Misses        172      185      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented May 6, 2025

CodSpeed Performance Report

Merging #502 will not alter performance

Comparing 05-06-feat_add_resolve_dts_api_for_resolving_.d.ts_files (0af0463) with main (f7c841c)

Summary

✅ 3 untouched benchmarks

@Boshen Boshen changed the title feat: add resolve_package_dts API for resolving .d.ts files for a node_modules package feat: add .d.ts resolver May 9, 2025
Boshen added a commit that referenced this pull request May 9, 2025
@Boshen
Revert "refactor!: remove modules options (#484)"
17b0d02 
This reverts commit f64911c.

closes #502
closes #493

I don't have have a clear understanding of how .d.ts resolution works
so reverting the `modules`.
@Boshen Boshen mentioned this pull request May 9, 2025
Merged
@Boshen Boshen closed this in 6e03810 May 9, 2025
@Boshen Boshen closed this in #504 May 9, 2025
@Boshen Boshen deleted the 05-06-feat_add_resolve_dts_api_for_resolving_.d.ts_files branch May 9, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sxzz sxzz Awaiting requested review from sxzz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle imports from @types/foo type-only packages

1 participant

@Boshen